Search enhancements — synonyms/stop-words + facet surfacing#34
Merged
Conversation
…facing Scope (from the design's optional menu): synonyms/stop-words and facet surfacing. Semantic/embeddings search deferred to a future spec. - ContentSearchProperties (open-elements.content.search.synonyms/stop-words) + SearchSettingsInitializer (ApplicationRunner @order 40, gated on meilisearch.enabled): pushes them via MeilisearchClient.updateSettings (no reindex); no-op when unset; failure logged, not fatal. - Facet surfacing: SearchHits gains a facets field; ContentSearchService.search requests facets:[categories] and returns their counts. - Semantic search off by default -> keyword search unchanged (non-regression). - Tests: SearchSettingsInitializerTest + ContentSearchServiceTest.searchSurfacesFacets. 159 tests green. steps.md; CLAUDE.md (roadmap 001-017 complete). Refs #33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two opt-in Phase 4 search enhancements from the design's menu. Semantic/embeddings search is deferred to a future spec (heavy: embedder provider + indexing cost), per the design's open question and your scope choice.
Spec
docs/specs/017-search-enhancements/{design,behaviors,steps}.mdChanges
ContentSearchProperties(open-elements.content.search.synonyms/stop-words) +SearchSettingsInitializer(startup runner) pushing them viaMeilisearchClient.updateSettings— no data reindex, no-op when unset, failure-tolerantSearchHits.facets;search_contentreturns category facet counts alongside hitsTest coverage
SearchSettingsInitializerTest(settings pushed viaupdateSettings; no-op when empty;buildSettings) +ContentSearchServiceTest.searchSurfacesFacets. Live synonym/stop-word effects are Meilisearch's (verified against a live instance). Full suite 159 green (non-regression). Both reviews clean.Closes #33
🤖 Generated with Claude Code